[links-list] Re: 0.95 disabling HTTP Basic Auth?

Mikulas Patocka mikulas at artax.karlin.mff.cuni.cz
Wed Jan 3 11:44:37 PST 2001


> Is there any way I could help diagnose or perhaps even try to fix
> the problem that caused you to disable HTTP Basic Auth in 0.95? I
> use that feature many times a day, and without it links can no
> longer be the one browser I use for everything, which would seem a
> shame.
> 
> I've patched my own build of 0.95 to re-enable HTTP Basic Auth
> (although, that really just means that my 0.95 is nothing more than
> 0.94 plus some language file changes and the version number change),
> and it continues to work fine as always.
> 
> What sort of problem led you to disable the Basic Auth? Could you
> tell me a test I could try to reproduce it?
> 
> -Bennett

It is not a one line fix. It uses extremely ugly message queue between
http requester and session - ignoring the fact that one http connection
may be shared between sessions and there can exist backgound connection
without a session.

Mikulas


---------- Forwarded message ----------
Date: Tue, 2 Jan 2001 13:49:21 +0100 (CET)
From: Mikulas Patocka <mikulas at artax.karlin.mff.cuni.cz>
To: Sergei Borushevsky <b_sp at usa.net>
Subject: [links-list] HTTP auth in Links

Hi.

HTTP auth is really buggy, I had to disable it in Links.

Go to www.freshmeat.net, click on 'lounge', press '<-' immediatelly, wait
until page loads in background, exit links => memory leak.

Go to www.freshmeat.net, click on 'lounge', press '<-' immediatelly,
select 'Flush all caches', click on 'lounge' again => segfault.

The problem is that you are assuming that connection has always session
attached to it. It is wrong. If the user cancel request, it is loaded on
background without session; if one file is loaded in more sessions, there
is only one connection shared between these sessions. 

You should remove the test for authentication from http_got_header and
test for the need to authenticate in session.c - at the same place where
redirects are tested. Possibly also remove the question queue.

Also remove S_QUESTION. You have enough information about connection
(including full header), so you don't need S_QUESTION.

Mikulas








_______________________________________________
links-list mailing list
links-list at appwatch.com
http://mailman.appwatch.com/listinfo/links-list



More information about the links-list mailing list